Review

Differences between revisions 7 and 8
Revision 7 as of 2011-09-28 14:38:55
Size: 3827
Editor: allison
Comment:
Revision 8 as of 2011-09-28 19:02:28
Size: 4194
Editor: allison
Comment:
Deletions are marked like this. Additions are marked like this.
Line 38: Line 38:

Once you've created the ticket, click the "Start review" button on the bottom of the page. On the next page, fill in the "Review comment" field with:

{{{
You can track the status of your ongoing application on Launchpad.

https://bugs.launchpad.net/ubuntu-app-review-board/+bug/######
}}}

Then click the "Submit to ARB" button at the bottom of the page.

New Submissions

New submissions to the ARB come through the myapps.developer.ubuntu.com web interface. If you have a reviewer account on this system (there's still some development work to do to create a general-purpose ARB queue in the interface, so not all ARB members have accounts yet), log in, and you'll see a link to "View applications up for review". At the moment, we manually create a Launchpad ticket for ARB submissions (apps with $0.00 price and a FLOSS license), using the following template:

NOTE: This submission was sent through the MyApps process.

= Application Review For <application name> =

 * Name: <submitter's name>
 * Email: <submitter's email>
 * Application name:
 * Tagline: 
 * Keywords:
 * Description:
 * License:
 * Support URL:
 * Package file (link):
 * Images (links):
   * 128x128:
   * 64x64:
   * 32x32:
   * 16x16:
   * Screenshot:
 * Known issues:
  * Issue.
  * Issue.

=== Status ===

<one of the states from http://developer.ubuntu.com/publish/application-states/, not the same as the bug state in Launchpad>

=== Application Notes ===

<additional notes about the application, if any>

Once you've created the ticket, click the "Start review" button on the bottom of the page. On the next page, fill in the "Review comment" field with:

You can track the status of your ongoing application on Launchpad.

https://bugs.launchpad.net/ubuntu-app-review-board/+bug/######

Then click the "Submit to ARB" button at the bottom of the page.

Review

Check the app for the following criteria, noting each as Pass/Fail, and including any comments. Add your results as a comment to the bug ticket for the submission.

Packaging

  • The application is well packaged using the Debian packaging system
  • All correct dependencies are met
  • Application installs cleanly
  • Application can be removed cleanly
  • Includes suitable copyright and licensing content
  • Application integrates into the desktop, with appropriate Launcher or menu entries

Run Tests

  • Application runs correctly
  • Major features operate as expected
  • Does not perform any malicious actions

Content

  • Content is suitable under the terms of the Ubuntu Code Of Conduct

If the app fails on any points, the reviewer will contact the submitter with suggestions for changes.

Voting

When the the reviewer considers the application ready for vote, the reviewer will raise it on the ARB mailing list. Votes on the application are made in the bug ticket comments, using the format:

= Application Review Board Response =

 * '''MEMBER''': <ARB member's name>
 * '''VOTE''': <+1 or -1>
 * '''NOTES''': <additional input on the request, if any>

If the voting for a particular app happens on the mailing list, or in IRC, one member may post a list of all the votes in one comment.

  • Three or more +1 votes mean the application is approved.
  • Three or more -1 votes mean the application is rejected.
  • If there are questions about an application, it may be held for further discussion and review.

Pre-upload review procedure

Before uploading a package to the ARB PPA, the ARB member should quickly go through this checklist to make sure not to miss anything:

  • Make sure the screenshot/icon branch has been merged and published (can take a while).
  • Look for typos in the packaging, one that we missed was a typo in the Screenshot or Icon name
  • Make sure the version number is consistent with: <upstream>-0extras<release.X where X starts at 1 with the first upload. Example: 1.2.3-0extras11.04.1 for the first upload of a package with the upstream version 1.2.3

  • Merge changelog entries to only have one entry per upload to the extras PPA
  • Triple check the target distro
  • Run lintian on both source and binary package one last time
  • Upload to the PPA. Make sure it builds fine and that it then shows up on extras.ubuntu.com (within 24 hours).
  • Check in Software Center that it shows up properly and installs fine.
  • [OPTIONAL] Blog about it

AppReviewBoard/Review (last edited 2012-11-15 16:51:23 by bhavi)