Differences between revisions 13 and 15 (spanning 2 versions)
Revision 13 as of 2006-02-02 22:40:45
Size: 2849
Editor: bur91-2-82-231-159-240
Revision 15 as of 2007-08-02 12:10:42
Size: 2812
Editor: AC81DDEA
Comment: typo
Deletions are marked like this. Additions are marked like this.
Line 27: Line 27:
 * Check if {{{ debian/copyright }}} is correct, acurate and complete.  * Check if {{{ debian/copyright }}} is correct, accurate and complete.
Line 51: Line 51:
["CategoryMOTU"] CategoryDocumentation CategoryCleanup ["CategoryMOTU"]

The page intends to list tips to do a proper review and don't miss common bugs. It can give some hints how to review packages e.g. on [:REVU]

[ Some suggestions from Debian ]

[ Some more suggestions from Debian (this time from the FTP masters instead of a random maintainer)]

Same version, new revision

If you review another revision of an existing package, be sure to have a copy of the old version around.

# get source of new version
mkdir orig; cd orig; apt-get source <package>; cd ..
debdiff orig/<package>_old-version.dsc <package>_new-version.dsc | less

This should give a nice overview of what changed, make notes of what to double check or ask the maintainer.

Thing always to do

Always check

  •  head -n1 debian/changelog  to have the correct release target.

  • If debian/rules changed, ask the maintainer, what he intended to do.

  • Make sure the original tarballs are the same (md5sum(1)).

  • Use interdiff(1) (patchutils package) against the .diff.gz, and debdiff(1) (devscripts package) against your test-built binary packages to examine what you've changed (and ensure it tallies with what you expected to change).

    • Use filterdiff to exclude generated or annoying parts
  • Check if  debian/copyright  is correct, accurate and complete.

Build test

Before building the package, check debian/rules and the Makefile, to be sure the package doesn't install into /usr.

When testing if the package builds, it is useful to run debuild -S again after debuild, and check the diff for files not cleaned during debuild. The only files in the diff after that should be debian/*.

After it's built

If you built the package (PbuilderHowto), install it and

  • check /var/lib/dpkg/info/<package>.list if everything is in the right place

  • do apt-cache show <package> to check changed dependencies

  • run lintian on the resulting debs.

REVU Reviewing

To faciliate reviewing in [:REVU], you can ask any REVU Admin to do a revu-build as described here:


MOTU/Packages/Reviewing/Tips (last edited 2008-08-06 16:27:26 by localhost)