Tips
1157
Comment: add category MOTU
|
1303
Add Debian ftpmasters' opinion on reviewing packages
|
Deletions are marked like this. | Additions are marked like this. |
Line 4: | Line 4: |
[http://ftp-master.debian.org/REJECT-FAQ.html Some more suggestions from Debian (this time from the FTP masters instead of a random maintainer)] |
The page intends to list tips to do a proper review and don't miss common bugs.
[http://people.debian.org/~mpalmer/sponsorship_checklist.html Some suggestions from Debian ] [http://ftp-master.debian.org/REJECT-FAQ.html Some more suggestions from Debian (this time from the FTP masters instead of a random maintainer)]
Same version, new revision
If you review another revision of an existing package, be sure to have a copy of the old version around.
# get source of new version mkdir orig; cd orig; apt-get source <package>; cd .. debdiff orig/<package>_old-version.dsc <package>_new-version.dsc | less
This should give a nice overview of what changed, make notes of what to double check or ask the maintainer.
Thing always to do
Always check
head -n1 debian/changelog
to have the correct release target.If debian/rules changed, ask the maintainer, what he intended to do.
Make sure the original tarballs are the same (md5sum(1)).
After it built
If you built the package (PbuilderHowto), install it and
check /var/lib/dpkg/info/<package>.list if everything is in the right place
do apt-cache show <package> to check changed dependencies
["CategoryMOTU"] CategoryDocumentation CategoryCleanup
MOTU/Packages/Reviewing/Tips (last edited 2008-08-06 16:27:26 by localhost)