indicator-location
The source for this document can be gotten from Bazaar:
$ bzr cat lp:indicator-location/MERGE-REVIEW
This documents the expections that the project has on what both submitters and reviewers should ensure that they've done for a merge into the project.
Submitter Responsibilities
- Ensure the project compiles and the test suite executes without error
- Ensure that non-obvious code has comments explaining it
- If the change works on specific profiles, please include those in the merge description.
Reviewer Responsibilities
- Did the Jenkins build compile? Pass? Run unit tests successfully?
- Are there appropriate tests to cover any new functionality?
- If the description says this effects the phone profile:
- Run tests indicator-location/unity8*
- If the description says this effects the desktop profile:
- Run tests indicator-location/unity7*
Process/Merges/Checklists/indicator-location (last edited 2014-01-31 20:20:11 by cpe-76-182-235-222)