|Deletions are marked like this.||Additions are marked like this.|
|Line 3:||Line 3:|
|The source for this document can be gotten from Bazaar:||The source for this document (minus this header) can be gotten from Bazaar:|
The source for this document (minus this header) can be gotten from Bazaar:
$ bzr cat lp:upstart-app-launch/MERGE-REVIEW
This documents the expections that the project has on what both submitters and reviewers should ensure that they've done for a merge into the project.
- Ensure the project compiles and the test suite executes without error
- Ensure that non-obvious code has comments explaining it
- Did the Jenkins build compile? Pass? Run unit tests successfully?
- Are there appropriate tests to cover any new functionality?
- If this MR effects application startup:
- Run test case: upstart-app-launch/click-app
- Run test case: upstart-app-launch/legacy-app
- Run test case: upstart-app-launch/secondary-activation