HowtoReviewPullRequests

Revision 3 as of 2010-06-09 21:25:02

Clear message

Pull requests come into the Ubuntu Kernel Team mailing list all the time. This write up is intended to give instruction on how to review the patches from one such pull request.

Pull request email:

The following changes since commit 88b50ff9b578518170f285b92542619ee80465ff:
  Stefan Bader (1):
        UBUNTU: Start new release

are available in the git repository at:

  git://kernel.ubuntu.com/bradf/ubuntu-lucid-wiki lp666xxx

Brad Figg (1):
      Minor change for wiki example

 debian.master/NOTES |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

Pre-review prep:

git clone git://kernel.ubuntu.com/ubuntu/ubuntu-lucid.git
cd ubuntu-lucid
git fetch
git checkout -b review-import origin/master
git fetch git://kernel.ubuntu.com/bradf/ubuntu-lucid-wiki lp666xxx
git reset --hard FETCH_HEAD

At this point all the patches are available for review.

Review with:

git log -p $(git merge-base origin/mvl-dove dove-import)..

Advanced Reviewing:

However, the Ubuntu kernel team has developed a couple of nice scripts which help with reviewing a large number of patches. First you need to install the kteam-tools from the kteam-tools git repository at git://kernel.ubuntu.com/ubuntu/kteam-tools.git. Add the maintscripts directory to your path.

Review with:

maint-do-review file.txt $(git merge-base origin/mvl-dove dove-import)..