HowtoReviewPullRequests

Differences between revisions 3 and 4
⇤ ← Revision 3 as of 2010-06-09 21:25:02 →
Size: 1461
Editor: pool-98-108-129-180
Comment:
← Revision 4 as of 2010-06-12 22:19:48 → ⇥
Size: 1738
Editor: pool-98-108-129-180
Comment:
Deletions are marked like this. Additions are marked like this.
Line 4: Line 4:
'''Pull request email:''' '''Example pull request email'''
Line 21: Line 21:
'''Pre-review prep:''' === Pre-review prep ===
Before you are able to actually review the changes, there is some prep work that must be done first. The following is just an example of how to
create a sandbox area with everything needed to review the changes indicated in the '''Example pull request email''' above.
Line 33: Line 36:
=== Basic Review ===
One way to review the commits is with a single git command.
Line 38: Line 44:
'''Advanced Reviewing:''' === Advanced Review ===
Line 41: Line 47:
a large number of patches. First you need to install the kteam-tools from the kteam-tools git repository
at git://kernel.ubuntu.com/ubuntu/kteam-tools.git. Add the '''maintscripts''' directory to your path.		 a large number of patches. To see how to obtain a copy of these scripts check out [[Kernel/kteam-tools|this wiki page]].

Pull requests come into the Ubuntu Kernel Team mailing list all the time. This write up is intended to give instruction on how to review the patches from one such pull request.

Example pull request email 

The following changes since commit 88b50ff9b578518170f285b92542619ee80465ff:
  Stefan Bader (1):
        UBUNTU: Start new release

are available in the git repository at:

  git://kernel.ubuntu.com/bradf/ubuntu-lucid-wiki lp666xxx

Brad Figg (1):
      Minor change for wiki example

 debian.master/NOTES |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

Pre-review prep

Before you are able to actually review the changes, there is some prep work that must be done first. The following is just an example of how to create a sandbox area with everything needed to review the changes indicated in the Example pull request email above. 

git clone git://kernel.ubuntu.com/ubuntu/ubuntu-lucid.git
cd ubuntu-lucid
git fetch
git checkout -b review-import origin/master
git fetch git://kernel.ubuntu.com/bradf/ubuntu-lucid-wiki lp666xxx
git reset --hard FETCH_HEAD

At this point all the patches are available for review.

Basic Review

One way to review the commits is with a single git command.

Review with: 

git log -p $(git merge-base origin/mvl-dove dove-import)..

Advanced Review

However, the Ubuntu kernel team has developed a couple of nice scripts which help with reviewing a large number of patches. To see how to obtain a copy of these scripts check out this wiki page.

Review with: 

maint-do-review file.txt $(git merge-base origin/mvl-dove dove-import)..

Kernel/Dev/HowtoReviewPullRequests (last edited 2010-06-30 19:43:30 by pool-98-108-129-180)