Unity8
Differences between revisions 7 and 38 (spanning 31 versions)
|
Size: 2048
Comment:
|
← Revision 38 as of 2017-03-28 21:55:58 ⇥
Size: 2558
Comment: Packaging changes are reviewed on bileto publish
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 5: | Line 5: |
| * Copy & paste this checklist into the MP description and answer each question (please expound if you skipped a step or have an unusual answer): | |
| Line 6: | Line 7: |
| * Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes) * Did you build your software in a clean pbuilder chroot or ppa? * Did you build your software in a clean pbuilder armhf chroot or ppa? * Has your component "TestPlan” been executed successfully on emulator, N4? * Has a 5 minute exploratory testing run been executed on N4? * If you changed the packaging (debian), did you subscribe a core-dev to this MP? * If you changed the UI, did you subscribe the design-reviewers to this MP? * What components might get impacted by your changes? * Have you requested review by the teams of these owning components? |
* Are there any related MPs required for this MP to build/function as expected? Please list. * Did you perform an exploratory manual test run of your code change and any related functionality? * If you changed the UI, has there been a design review? |
| Line 16: | Line 11: |
| * If your branch requires a PPA as prerequisite in order for CI to build, place something like this in the Description field: Prereq-archive: ppa:ci-train-ppa-service/2022 * Make sure you have set a commit message. Commit messages should have the following format: * A single-line summary or short description of the change (something no longer than 80 or 90 chars) * Follow-up lines explaining the change in a bit more detail if needed (make sure not to leave an empty line, just use one line break here). Make sure to mention things like new dependencies, bug numbers, or anything else that an outside developer or user might be interested in. This all ends up in debian/changelog. * An empty line (if you're going to have this next section). * An even more complete explanation, if needed. This will not go in debian/changelog, but will go into bzr. So more detailed comments about reorganizing code or similar would be appropriate here. * Please follow our [[https://docs.google.com/a/canonical.com/document/d/1gd87Wo_CSB0DpFWLpTKIIXQfdmFncrq0PHSr9H2PTnk/|style guide]] |
|
| Line 18: | Line 21: |
| * If you have been asked to review and are not on the unity-team, please review for any interdependency and paste the associated MP reference in a comment * Ensure the commit message has the proper format (see above) * Copy & paste the checklist into MP review comment * Questions to answer: |
|
| Line 19: | Line 27: |
| Note: Please ensure you include the following form filled out and submitted along side your code to the MP ticket. Note: A Reviewer usually is responsible for a single component; since we ask for reviewers to be subscribed that might see an impact by this MP this mean that we get one-to-many reviewers contributing to the MP review process. Below the checklist that a reviewer should follow taking the viewpoint of his component, which might or might not be the same as the component this MP is targeted against. * Are any changes against your component pending/needed to land the MP under review in a functional state and are those called out explicitly by the submitter? * Did you do exploratory testing related to the component you own with the MP changeset included? * Has the submitter requested review by all the relevant teams/reviewres? * If you are the reviewer owning the component the MP is against, have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut? |
* Did you perform an exploratory manual test run of the code change and any related functionality? * Did CI run pass? If not, please explain why. |
| Line 31: | Line 32: |
| * ensure that the checklists have been properly filled out by submitter and all reviewers | * Questions to answer: * Is the MP approved by at least 1 member of unity-team? * Are the approvals equal to or greater than the disapprovals? * Is the checklist completed to satisfaction? * Has the [[https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8|TestPlan]] been executed successfully on emulator, N4? |
MP Submission Checklist Template
Note: Please ensure you include the following form filled out and submitted along side your code to the MP ticket.
Copy & paste this checklist into the MP description and answer each question (please expound if you skipped a step or have an unusual answer):
* Are there any related MPs required for this MP to build/function as expected? Please list. * Did you perform an exploratory manual test run of your code change and any related functionality? * If you changed the UI, has there been a design review?
- If your branch requires a PPA as prerequisite in order for CI to build, place something like this in the Description field:
- Prereq-archive: ppa:ci-train-ppa-service/2022
- Make sure you have set a commit message. Commit messages should have the following format:
- A single-line summary or short description of the change (something no longer than 80 or 90 chars)
- Follow-up lines explaining the change in a bit more detail if needed (make sure not to leave an empty line, just use one line break here). Make sure to mention things like new dependencies, bug numbers, or anything else that an outside developer or user might be interested in. This all ends up in debian/changelog.
- An empty line (if you're going to have this next section).
- An even more complete explanation, if needed. This will not go in debian/changelog, but will go into bzr. So more detailed comments about reorganizing code or similar would be appropriate here.
Please follow our style guide
MP Review Checklist Template
- If you have been asked to review and are not on the unity-team, please review for any interdependency and paste the associated MP reference in a comment
- Ensure the commit message has the proper format (see above)
Copy & paste the checklist into MP review comment
- Questions to answer:
* Did you perform an exploratory manual test run of the code change and any related functionality? * Did CI run pass? If not, please explain why.
MP Landing Checklist Template
- Questions to answer:
- Is the MP approved by at least 1 member of unity-team?
- Are the approvals equal to or greater than the disapprovals?
- Is the checklist completed to satisfaction?
Has the TestPlan been executed successfully on emulator, N4?
Process/Merges/Checklists/Unity8 (last edited 2017-03-28 21:55:58 by saviq)