20160317
Differences between revisions 1 and 3 (spanning 2 versions)
419
Comment:
|
6406
|
Deletions are marked like this. | Additions are marked like this. |
Line 5: | Line 5: |
* Lockscreen: Need to deal with the duplicated code and add autopilot test, anything else? * launcher-rotation: Is it ok to add the option like this [[ https://code.launchpad.net/~feng-kylin/unity/unityshell-rotated-kylin |lp:~feng-kylin/unity/unityshell-rotated-kylin]] ? |
|
Line 7: | Line 9: |
* None | * Lockscreen and launcher-rotation |
Line 13: | Line 15: |
* None | {{{ 09:35:41 <handsome_feng> hi, everyone, sorry i'm latter 09:36:49 <handsome_feng> late... 09:38:18 <handsome_feng> marco ? eleni ? 09:38:31 <Trevinho> hi handsome_feng 09:38:45 <handsome_feng> hi :) 09:39:18 <Trevinho> Ah, we have a meeting to day... But time changed here, so in theory it was in in 1 hour 09:39:27 <Trevinho> is that too late for you? 09:41:20 <handsome_feng> er , yes, maybe we can make this meeting tomoro ? 09:41:33 <Trevinho> handsome_feng: no, well it's fine for me now... 09:41:37 <Trevinho> I'm going to change the event 09:43:10 <handsome_feng> OK 09:43:35 <Trevinho> handsome_feng: it's 16:30 there, right? 09:43:45 <handsome_feng> yes 09:43:49 <Trevinho> err, 16:43... :P 09:44:43 <handsome_feng> ... 09:45:28 <handsome_feng> you are right 09:46:14 <Trevinho> handsome_feng: no problem, let's do this quick and informal, there's no problem 09:46:23 <Trevinho> handsome_feng: or.... I don't know... what's the best plan 09:47:17 <handsome_feng> best plan of wizard ? 09:47:44 → jackyu joined (~jackyu@43.250.200.19) 09:48:08 <Trevinho> handsome_feng: so, I didn't get anything back from the design, let me ask willcooke 09:48:28 <Trevinho> Ouch, he's still not online... 09:48:33 <Trevinho> So, well I'll ask him later 09:48:35 <handsome_feng> @Trevinho OK, no problem 09:48:59 <Trevinho> However, I'd say your design is mostly fine. You can proceed with that, at least the logic part... Then if we need to tune the UI there's time. 09:49:19 <Trevinho> Ah, you need to handle also multi-monitor, I'd do the same as it's done in the lockscreen... 09:49:26 <Trevinho> So show that view in the monitor where's the pointer is 09:50:13 <handsome_feng> OK, Got this 09:51:14 → willcooke joined (~willcooke@ubuntu/member/willcooke) 09:51:59 <handsome_feng> Hi, willcooke 09:52:16 <willcooke> hi handsome_feng 09:52:24 <Trevinho> willcooke: hey, did you get anything back from John/design about the wizard? 09:52:24 <handsome_feng> we are just talk about the wizard 09:52:42 <willcooke> Not quite yet, but they are due to review "real soon now" 09:52:52 <willcooke> I will chase him now and see if I can get a time line 09:53:14 <Trevinho> nice 09:54:47 <handsome_feng> Thank you , so let's wait :) 09:57:17 <handsome_feng> marco, anything else about the lockscreen ? 09:58:15 <Trevinho> handsome_feng: no, I've seen you're still working on it... Are you already ready for a review? 09:59:47 <handsome_feng> I have not write the autopilot test ... 10:00:31 <Trevinho> Well, those are a little hard to do in the lockscreen, you can add some unit-tests if you want 10:00:37 <Trevinho> but autopilot is complicated there 10:00:38 <handsome_feng> And also should handle some detals 10:00:55 <Trevinho> Ok, fine... Once you're ok, feel free to propose the merge request, and I'll review it 10:01:11 <Trevinho> I've seen some progress also in the launcher rotation... 10:01:17 ⇐ liuxg quit (~liuxg@123.119.108.234) Read error: Connection reset by peer 10:01:52 <handsome_feng> Yes, I just add the option about launcher position 10:01:55 <Trevinho> Ah, one thing I've seen there that you should change: you added a sigc::signal<void> launcher_position_changed; 10:02:01 → liuxg joined (~liuxg@123.119.108.234) 10:02:18 <Trevinho> But you don't need that... just use nux::RWProperty<LauncherPosition> launcher_position; (just use nux::Property) 10:02:24 <Trevinho> and that gives you the signal for free 10:02:26 <Trevinho> so you can just do 10:02:39 <Trevinho> launcher_position.changed.connect() ... 10:03:08 <Trevinho> Also, maybe, instead of using LauncherWidth/LauncherHeight, we can just use LauncherSize at this point 10:03:24 <handsome_feng> er, i put it there and just forget it ... 10:03:25 <Trevinho> You rename that value and use for both the cases. 10:03:46 <handsome_feng> ok, i have do this in some small functions 10:05:25 <Trevinho> good 10:05:43 <Trevinho> Ah, I wanted to mention that the list of bugs we want to target for 16.04, have now been moved to 10:05:43 <Trevinho> http://reqorts.qa.ubuntu.com/reports/rls-mgr/rls-x-incoming-bug-tasks.html 10:06:03 <Trevinho> The same as searching for the "rls-x-incoming" tag in launchpad, but shows all the projects involved 10:06:05 <handsome_feng> And i should use launcher_position.changed to info the dash/launcher/panel to redraw , right ? 10:06:18 <Trevinho> So,. if you think there's anything important, you can just tag with that 10:06:28 <Trevinho> handsome_feng: yep 10:06:52 <Trevinho> handsome_feng: that property will both allow you to handle the value, and being notified when changed 10:07:30 <handsome_feng> Trevinho: Thank you , got it 10:07:46 <Trevinho> handsome_feng: you can look for examples around in the code, it's all quite easy 10:08:21 <handsome_feng> ok , i just learn from the code too 10:08:33 <Trevinho> Just remember that if you use lambda_functions to connect to signals, you need to disconnect from them (using a connnection::wrapper or a connection::manager)... Otherwise you might experience crashes. 10:08:58 <Trevinho> In xenial there's also the sigc::track_obj feature, but it's probably too early to use it. 10:10:19 <handsome_feng> oh, write it down in my notebook 10:13:16 <handsome_feng> Thank you for your advise , seems all things have discussed 10:15:00 <handsome_feng> maybe we can wrap this up? 10:17:46 <Trevinho> handsome_feng: yeah, sorry... I got int a bug :P... However yes 10:17:50 <Trevinho> I think we're done. 10:17:51 <Trevinho> Thanks 10:18:24 <handsome_feng> Thanks ! and bye ! maro :) }}} |
Line 16: | Line 96: |
* Get design feedback on wizard * Finish lockscreen branch |
Meeting with Ubuntu desktop team for work on Unity 7.
Agenda
- About wizard, Feedback on design
- Lockscreen: Need to deal with the duplicated code and add autopilot test, anything else?
launcher-rotation: Is it ok to add the option like this lp:~feng-kylin/unity/unityshell-rotated-kylin ?
Action Items from last meeting
- Lockscreen and launcher-rotation
Meeting Notes
- None
Meeting Log
09:35:41 <handsome_feng> hi, everyone, sorry i'm latter 09:36:49 <handsome_feng> late... 09:38:18 <handsome_feng> marco ? eleni ? 09:38:31 <Trevinho> hi handsome_feng 09:38:45 <handsome_feng> hi :) 09:39:18 <Trevinho> Ah, we have a meeting to day... But time changed here, so in theory it was in in 1 hour 09:39:27 <Trevinho> is that too late for you? 09:41:20 <handsome_feng> er , yes, maybe we can make this meeting tomoro ? 09:41:33 <Trevinho> handsome_feng: no, well it's fine for me now... 09:41:37 <Trevinho> I'm going to change the event 09:43:10 <handsome_feng> OK 09:43:35 <Trevinho> handsome_feng: it's 16:30 there, right? 09:43:45 <handsome_feng> yes 09:43:49 <Trevinho> err, 16:43... :P 09:44:43 <handsome_feng> ... 09:45:28 <handsome_feng> you are right 09:46:14 <Trevinho> handsome_feng: no problem, let's do this quick and informal, there's no problem 09:46:23 <Trevinho> handsome_feng: or.... I don't know... what's the best plan 09:47:17 <handsome_feng> best plan of wizard ? 09:47:44 → jackyu joined (~jackyu@43.250.200.19) 09:48:08 <Trevinho> handsome_feng: so, I didn't get anything back from the design, let me ask willcooke 09:48:28 <Trevinho> Ouch, he's still not online... 09:48:33 <Trevinho> So, well I'll ask him later 09:48:35 <handsome_feng> @Trevinho OK, no problem 09:48:59 <Trevinho> However, I'd say your design is mostly fine. You can proceed with that, at least the logic part... Then if we need to tune the UI there's time. 09:49:19 <Trevinho> Ah, you need to handle also multi-monitor, I'd do the same as it's done in the lockscreen... 09:49:26 <Trevinho> So show that view in the monitor where's the pointer is 09:50:13 <handsome_feng> OK, Got this 09:51:14 → willcooke joined (~willcooke@ubuntu/member/willcooke) 09:51:59 <handsome_feng> Hi, willcooke 09:52:16 <willcooke> hi handsome_feng 09:52:24 <Trevinho> willcooke: hey, did you get anything back from John/design about the wizard? 09:52:24 <handsome_feng> we are just talk about the wizard 09:52:42 <willcooke> Not quite yet, but they are due to review "real soon now" 09:52:52 <willcooke> I will chase him now and see if I can get a time line 09:53:14 <Trevinho> nice 09:54:47 <handsome_feng> Thank you , so let's wait :) 09:57:17 <handsome_feng> marco, anything else about the lockscreen ? 09:58:15 <Trevinho> handsome_feng: no, I've seen you're still working on it... Are you already ready for a review? 09:59:47 <handsome_feng> I have not write the autopilot test ... 10:00:31 <Trevinho> Well, those are a little hard to do in the lockscreen, you can add some unit-tests if you want 10:00:37 <Trevinho> but autopilot is complicated there 10:00:38 <handsome_feng> And also should handle some detals 10:00:55 <Trevinho> Ok, fine... Once you're ok, feel free to propose the merge request, and I'll review it 10:01:11 <Trevinho> I've seen some progress also in the launcher rotation... 10:01:17 ⇐ liuxg quit (~liuxg@123.119.108.234) Read error: Connection reset by peer 10:01:52 <handsome_feng> Yes, I just add the option about launcher position 10:01:55 <Trevinho> Ah, one thing I've seen there that you should change: you added a sigc::signal<void> launcher_position_changed; 10:02:01 → liuxg joined (~liuxg@123.119.108.234) 10:02:18 <Trevinho> But you don't need that... just use nux::RWProperty<LauncherPosition> launcher_position; (just use nux::Property) 10:02:24 <Trevinho> and that gives you the signal for free 10:02:26 <Trevinho> so you can just do 10:02:39 <Trevinho> launcher_position.changed.connect() ... 10:03:08 <Trevinho> Also, maybe, instead of using LauncherWidth/LauncherHeight, we can just use LauncherSize at this point 10:03:24 <handsome_feng> er, i put it there and just forget it ... 10:03:25 <Trevinho> You rename that value and use for both the cases. 10:03:46 <handsome_feng> ok, i have do this in some small functions 10:05:25 <Trevinho> good 10:05:43 <Trevinho> Ah, I wanted to mention that the list of bugs we want to target for 16.04, have now been moved to 10:05:43 <Trevinho> http://reqorts.qa.ubuntu.com/reports/rls-mgr/rls-x-incoming-bug-tasks.html 10:06:03 <Trevinho> The same as searching for the "rls-x-incoming" tag in launchpad, but shows all the projects involved 10:06:05 <handsome_feng> And i should use launcher_position.changed to info the dash/launcher/panel to redraw , right ? 10:06:18 <Trevinho> So,. if you think there's anything important, you can just tag with that 10:06:28 <Trevinho> handsome_feng: yep 10:06:52 <Trevinho> handsome_feng: that property will both allow you to handle the value, and being notified when changed 10:07:30 <handsome_feng> Trevinho: Thank you , got it 10:07:46 <Trevinho> handsome_feng: you can look for examples around in the code, it's all quite easy 10:08:21 <handsome_feng> ok , i just learn from the code too 10:08:33 <Trevinho> Just remember that if you use lambda_functions to connect to signals, you need to disconnect from them (using a connnection::wrapper or a connection::manager)... Otherwise you might experience crashes. 10:08:58 <Trevinho> In xenial there's also the sigc::track_obj feature, but it's probably too early to use it. 10:10:19 <handsome_feng> oh, write it down in my notebook 10:13:16 <handsome_feng> Thank you for your advise , seems all things have discussed 10:15:00 <handsome_feng> maybe we can wrap this up? 10:17:46 <Trevinho> handsome_feng: yeah, sorry... I got int a bug :P... However yes 10:17:50 <Trevinho> I think we're done. 10:17:51 <Trevinho> Thanks 10:18:24 <handsome_feng> Thanks ! and bye ! maro :)
Action Items
- Get design feedback on wizard
- Finish lockscreen branch
Meeting Links
Ubuntu Kylin/Meeting/2016/20160317 (last edited 2016-03-17 13:23:31 by localhost)